Permalink
Commits on Mar 16, 2017
  1. Layout <mspace> elements.

    emilio committed Mar 16, 2017
  2. Expose font metrics data to layout.

    fred-wang authored and emilio committed Mar 16, 2017
  3. Add MathML length parsing.

    fred-wang authored and emilio committed Mar 16, 2017
  4. Expose math font data from harfbuff.

    fred-wang authored and emilio committed Mar 16, 2017
  5. Base DOM and layout setup.

    emilio committed Mar 16, 2017
  6. Remove FrameHost::consoleMessageStorage() methods

    sashab Commit bot
    sashab authored and Commit bot committed Mar 16, 2017
    Remove FrameHost::consoleMessageStorage() methods, since these can now
    call consoleMessageStorage() directly in Page.
    
    BUG=691794
    
    Review-Url: https://codereview.chromium.org/2732113004
    Cr-Commit-Position: refs/heads/master@{#457306}
  7. Added core/css/properties/README.md.

    BugsNash authored and Commit bot committed Mar 16, 2017
    Added core/css/properties/README.md, detailing the purpose and status of
    CSS property APIs as well as the steps involved in adding a new
    property API.
    
    BUG=545324
    
    Review-Url: https://codereview.chromium.org/2746793002
    Cr-Commit-Position: refs/heads/master@{#457305}
  8. [DevTools] Make ConsoleModel not inherit from SDKModel

    dgozman authored and Commit bot committed Mar 16, 2017
    SDK.MultiTargetConsoleModel now manages ConsoleModel instances.
    
    This is in preparation to extracting ConsoleModel out of SDK and
    turning it into ConsoleView's presentation model.
    
    BUG=none
    
    Review-Url: https://codereview.chromium.org/2748023006
    Cr-Commit-Position: refs/heads/master@{#457304}
  9. MD Settings: Prevent direct navigation to disabled Site Settings UI.

    freshp86 authored and Commit bot committed Mar 16, 2017
    BUG=699421
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2741343010
    Cr-Commit-Position: refs/heads/master@{#457303}
  10. Fix unsupported audio channel layout

    tguilbert Commit bot
    tguilbert authored and Commit bot committed Mar 16, 2017
    We currently do not check the returned channel layout when converting
    Ffmpeg to chrome channel layouts. This means that we still try to create
    audio buffers whenever we have an unsupported channel layout. This
    causes some tests to crash when hitting a DCHECK in AudioBuffer's ctor.
    
    This CL fixes the issue by erroring out early rather than trying to
    create an invalid AudioBuffer.
    
    BUG=699373
    TEST=manually checked it didn't crash anymore
    
    Review-Url: https://codereview.chromium.org/2748023004
    Cr-Commit-Position: refs/heads/master@{#457302}
  11. Update subtree paint properties when preserve-3d changes

    wangxianzhu authored and Commit bot committed Mar 16, 2017
    BUG=701878
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    
    Review-Url: https://codereview.chromium.org/2749403004
    Cr-Commit-Position: refs/heads/master@{#457301}
  12. [Android:WebAPK] Don't add webapp to homescreen if WebAPK install tim…

    pkotwicz authored and Commit bot committed Mar 16, 2017
    …es out part 2/3
    
    This CL:
    - Changes GooglePlayWebApkInstallDelegate#installAsync() to return a
      WebApkInstallResult in the callback.
    - Deletes unused GooglePlayWebApkInstallDelegate#canInstallWebApk().
    
    BUG=696132
    
    Review-Url: https://codereview.chromium.org/2728053002
    Cr-Commit-Position: refs/heads/master@{#457300}
  13. [Home] Add pull-handle to bottom toolbar

    iotitan authored and Commit bot committed Mar 16, 2017
    This change adds a pill-shaped handle to the bottom toolbar for Chrome
    Home indicating that it can be pulled up. To avoid refactoring large
    sections of code this is done in a relatively unorthodox way. The
    height of the toolbar needs to increase but the view hierarchy is
    uncondusive to change. So instead of wrapping the toolbar controls
    in a bottom-aligned view, a top margin is programmatically added when
    the views are inflated.
    
    The handle itself is programatically drawn and exists as an immediate
    child of the ViewResourceFrameLayout. This allows it to be captured in
    the screenshot used by the compositor and for it to be drawn on top
    of the other toolbar views (particularly the location bar). Both a
    normal and incognito version of the handle are maintained by the
    BottomToolbarPhone class.
    
    BUG=692865
    
    Review-Url: https://codereview.chromium.org/2744763005
    Cr-Commit-Position: refs/heads/master@{#457299}
  14. Delete proxy_resolver_perftest.cc

    eroman Commit bot
    eroman authored and Commit bot committed Mar 16, 2017
    There is little value in running this test continuously, as it is not very relevant anymore.
    
    BUG=701387
    
    Review-Url: https://codereview.chromium.org/2752713002
    Cr-Commit-Position: refs/heads/master@{#457298}
  15. Print too-long command line

    randomascii authored and Commit bot committed Mar 16, 2017
    When RegisterApplicationRestart fails with E_INVALIDARG it is supposed
    to indicate that the command line is too long. This error was hit on
    a recent test run and it was impossible to do further diagnosis because
    the command line is not printed, even though it is printed for other
    failure codes. This change prints the command line in the E_INVALIDARG
    case.
    
    The failure only happened once and was probably a Windows glitch since
    all evidence is that the command line was short enough. But, still.
    
    This change also removes some checks for win::VERSION_VISTA since Chrome
    requires Windows 7 or higher, and avoids some redundant calls to
    GetCommandLineString.
    
    Review-Url: https://codereview.chromium.org/2756603002
    Cr-Commit-Position: refs/heads/master@{#457297}
  16. Add "interactive" UI integration tests for PermissionRequestManager.

    tapted authored and Commit bot committed Mar 16, 2017
    Existing PermissionRequestManager tests use a
    MockPermissionPromptFactory which replaces the code that generates
    actual UI with stubs. To get coverage of the UI creation code, and to
    allow the set of permission prompts to be easily "invoked" for UI
    review, extend PermissionRequestManagerBrowserTest with one that uses
    "real" UI rather than a mock.
    
    Then, add "Dialog" BrowserTests for a range of permission types that can
    be requested. These are run on the bots or (optionally) interactively
    with a command such as `browser_tests
    --gtest_filter=BrowserDialogTest.Invoke --interactive
    --dialog=PermissionDialogTest.InvokeDialog_multiple`
    
    BUG=605667, 663935
    
    Review-Url: https://codereview.chromium.org/2569703004
    Cr-Commit-Position: refs/heads/master@{#457296}
  17. Revert of DevTools: move flow events tracking to TracingModel, suppor…

    pavelfeldman authored and Commit bot committed Mar 16, 2017
    …t cross-threads case (patchset #2 id:20001 of https://codereview.chromium.org/2746153005/ )
    
    Reason for revert:
    Breaks flow events completely.
    
    Original issue's description:
    > DevTools: move flow events tracking to TracingModel, support cross-threads case
    >
    > This implements support for tracking flow events in TracingModel and correctly supports the spec in terms of id matching for flow events.
    >
    > Review-Url: https://codereview.chromium.org/2746153005
    > Cr-Commit-Position: refs/heads/master@{#457245}
    > Committed: https://chromium.googlesource.com/chromium/src/+/56024c61ffdabb977c7645098cb4654c6a1fdcc1
    
    TBR=alph@chromium.org,caseq@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    
    Review-Url: https://codereview.chromium.org/2750133003
    Cr-Commit-Position: refs/heads/master@{#457295}
  18. Fix Default icon issue when cached icon file is corrupted.

    lgcheng Commit bot
    lgcheng authored and Commit bot committed Mar 16, 2017
    Some crahes lead to app cached icon file corruption. Re send icon
    request to ARC if bad icon is observed. Limit icon request to once per
    app per scale per user session.
    
    Bug=701979
    Test=Unit test added.
    Test=Manual test. Manual corrupted cached icon. See icon restored.
    
    Review-Url: https://codereview.chromium.org/2749973002
    Cr-Commit-Position: refs/heads/master@{#457294}
  19. Run optimize-png-files.sh on xxxhdpi search_sogu.png

    twellington Commit bot
    twellington authored and Commit bot committed Mar 16, 2017
    Result: 79588 => 49436 bytes (30152 bytes: 37%)
    
    BUG=
    
    Review-Url: https://codereview.chromium.org/2754723002
    Cr-Commit-Position: refs/heads/master@{#457293}
  20. [dxvavda] Mark NV12 textures as allowing overlays.

    jbauman2 authored and Commit bot committed Mar 16, 2017
    These can be used as overlays, though the type of image transport
    surface (DirectComposition or standard) and the scene layout will decide
    if they're actually used that way.
    
    BUG=678800
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    
    Review-Url: https://codereview.chromium.org/2752143002
    Cr-Commit-Position: refs/heads/master@{#457292}
  21. Import wpt@d43ffe4a9b92f4d6a4b7b0e974d17baf52169ce7

    chromium-wpt-export-bot authored and Commit Bot committed Mar 15, 2017
    Using wpt-import in Chromium a495f97.
    
    Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/8010
    
    Directory owners for changes in this CL:
    dom-dev@chromium.org:
      external/wpt/html
    
    TBR=qyearsley@chromium.org
    NOEXPORT=true
    
    Change-Id: Ia2313a6a81aa2be083d3c086d9a426c2fb4a161c
    Reviewed-on: https://chromium-review.googlesource.com/456019
    Reviewed-by: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
    Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#457291}
  22. Allow SpdySessionPool to find/create SpdySession with IP pooling disa…

    bnc Commit bot
    bnc authored and Commit bot committed Mar 16, 2017
    …bled.
    
    This is in preparation to support HTTP response status 421 Misdirected
    Request, when the client may retry the request on a different
    connection, preferably on one with IP based pooling disabled.
    
    * Add |enable_ip_based_pooling| argument to
      SpdySessionPool::FindAvailableSession().
    * Remove previously IP pooled session from
      SpdySessionPool::available_sessions_, SpdySessionPool::aliases_, and
      remove key from SpdySession::pooled_aliases, so that a new SpdySession
      can be created with the same key.
    * Add unittest; add test helper method.
    
    BUG=546991
    
    Review-Url: https://codereview.chromium.org/2756503002
    Cr-Commit-Position: refs/heads/master@{#457290}
  23. Roll src/third_party/catapult/ 4bfab43f3..64c8f1f30 (2 commits)

    catapult-deps-roller Commit bot
    catapult-deps-roller authored and Commit bot committed Mar 16, 2017
    https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4bfab43f3b02..64c8f1f30706
    
    $ git log 4bfab43f3..64c8f1f30 --date=short --no-merges --format='%ad %ae %s'
    2017-03-15 eakuefner Fix a couple busted links in CONTRIBUTING.md
    2017-03-15 eakuefner [Dashboard] Start using /list_tests's test_path_dict mode in test-picker
    
    Created with:
      roll-dep src/third_party/catapult
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, see:
    http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
    TBR=catapult-sheriff@chromium.org
    
    Review-Url: https://codereview.chromium.org/2747843005
    Cr-Commit-Position: refs/heads/master@{#457289}
  24. Fix crash when user disconnects It2Me host

    kelvinp Commit bot
    kelvinp authored and Commit bot committed Mar 16, 2017
    Cause:
    The delegating_signal_strategy_ pointer is destroyed on the network
    thread while It2meNativeMessagingHost keeps a raw pointer to it.
    
    Fix:
    DelegatingSignalStrategy will expose a callback that internally binds
    weak pointer.  This will allow the callback to be invoked safely from
    any thread even after the instance is destroyed.
    
    BUG=700152
    
    Review-Url: https://codereview.chromium.org/2747743004
    Cr-Commit-Position: refs/heads/master@{#457288}
  25. Roll src/third_party/pdfium/ 0029fb25b..c467d4619 (6 commits)

    pdfium-deps-roller Commit bot
    pdfium-deps-roller authored and Commit bot committed Mar 16, 2017
    https://pdfium.googlesource.com/pdfium.git/+log/0029fb25b9b6..c467d4619ebe
    
    $ git log 0029fb25b..c467d4619 --date=short --no-merges --format='%ad %ae %s'
    2017-03-15 npm Reset tree traversal when we think we're at the start
    2017-03-15 tsepez Use map of unique_ptr in cxfa_textparser.
    2017-03-15 tsepez remove CFX_ArrayTemplate from fxet_list.
    2017-03-15 thestig Refactor some CPDF_ColorSpace code.
    2017-03-15 thestig Clean up more CPDF_PSEngine code.
    2017-03-15 tsepez Fix botch introduced at 193e6ca, try 2.
    
    Created with:
      roll-dep src/third_party/pdfium
    BUG=680222
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, see:
    http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
    
    TBR=dsinclair@chromium.org
    
    Review-Url: https://codereview.chromium.org/2757443002
    Cr-Commit-Position: refs/heads/master@{#457287}
  26. HDR: Force raster into sRGB space when HDR is enabled

    ccameron-chromium authored and Commit bot committed Mar 16, 2017
    This ensures that colors will be consistent when viewing HDR content.
    
    This can be removed once crbug.com/701942 is stable enough to use.
    
    BUG=696742
    
    Review-Url: https://codereview.chromium.org/2748273003
    Cr-Commit-Position: refs/heads/master@{#457286}
  27. Add UMA histogram for popup actions on Android.

    charleszhao Commit bot
    charleszhao authored and Commit bot committed Mar 16, 2017
    This CL adds metrics for the pop-up blocked infobar on Android.
    
    BUG=650132
    
    Review-Url: https://codereview.chromium.org/2662163002
    Cr-Commit-Position: refs/heads/master@{#457285}
  28. [Android] Respect animation multiplier from Developer Options.

    sheepmaster authored and Commit bot committed Mar 16, 2017
    Review-Url: https://codereview.chromium.org/2743403006
    Cr-Commit-Position: refs/heads/master@{#457284}
  29. cmaa: remove dead code in shader.

    ds-hwang authored and Commit bot committed Mar 16, 2017
    BUG=535198
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    
    Review-Url: https://codereview.chromium.org/2750223002
    Cr-Commit-Position: refs/heads/master@{#457283}
  30. [Chromecast][Temporary] Disable AudioPlaybackWavPcm on device.

    mbjorge Commit bot
    mbjorge authored and Commit bot committed Mar 16, 2017
    In an effort to get a useful/clean signal from the unittests, the
    current failing tests are being disabled to get the system back to a
    green state. The disabled tests will be vigilantly monitored by mbjorge@
    and jonathanve@ to ensure they are fixed and not forgotten.
    
    Tracking hotlist: 461351
    
    BUG=internal b/36239152
    
    Review-Url: https://codereview.chromium.org/2745283006
    Cr-Commit-Position: refs/heads/master@{#457282}
  31. Revert of Move ui/gfx/codec/ into its own component. (patchset #7 id:…

    chrishtr Commit bot
    chrishtr authored and Commit bot committed Mar 16, 2017
    …120001 of https://codereview.chromium.org/2755563002/ )
    
    Reason for revert:
    Breaks a chromeos unittest.
    
    Original issue's description:
    > Move ui/gfx/codec/ into its own component.
    >
    > This is necessary to break an include cycle between cc and ui/gfx/ for upcoming
    > changes to cc/paint/.
    >
    > TBR=robertphillips@google.com
    >
    > BUG=665259
    >
    > Review-Url: https://codereview.chromium.org/2755563002
    > Cr-Commit-Position: refs/heads/master@{#457238}
    > Committed: https://chromium.googlesource.com/chromium/src/+/e3d8f58563aececeeaa395795e022ddadf23c93d
    
    TBR=rockot@chromium.org,sky@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=665259
    
    Review-Url: https://codereview.chromium.org/2751103004
    Cr-Commit-Position: refs/heads/master@{#457281}
  32. [MD settings] move font controls in MD settings

    dschuyler authored and Commit bot committed Mar 16, 2017
    This CL outdents some UI controlls to place them in the correct positions
    (they were indented too far). Also corrects some div tags.
    
    BUG=617712
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2751063003
    Cr-Commit-Position: refs/heads/master@{#457280}