Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drag_value.edit_string unexpected reset #2421

Merged
merged 3 commits into from
Dec 10, 2022
Merged

Conversation

tkkcc
Copy link
Contributor

@tkkcc tkkcc commented Dec 9, 2022

Make drag_value.edit_string None only during current focused widget update

Only two cases edit_string will be set to None (and reconstructed from value):

  1. current widget gains focus.
  2. current widget consumes up down key to change value.

Editing, Tabing and UpDown tested.

Close #2418
Close #2370

@tkkcc
Copy link
Contributor Author

tkkcc commented Dec 9, 2022

Still problematic. Editing DragValue then click another DragValue, the edit_string does not reset.

@tkkcc
Copy link
Contributor Author

tkkcc commented Dec 9, 2022

Fixed, add another reset on request_focus. Seems gained_focus is not satisfied this case.

@emilk
Copy link
Owner

emilk commented Dec 9, 2022

@mwcampbell worked on this code recently - maybe you wanna take a look at this so it doesn't break AccessKit?

@mwcampbell
Copy link
Contributor

I reviewed the code and tested it using only the keyboard and a screen reader, and it looks good to me.

@emilk
Copy link
Owner

emilk commented Dec 10, 2022

Thanks for taking a look @mwcampbell! And thanks for the PR @tkkcc!

@emilk emilk merged commit e7471f1 into emilk:master Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DragValue not support empty content in text editing mode DragValue max_decimals not working on master
3 participants