Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make dragvalue textedit style consistent with button #2649

Merged
merged 4 commits into from
Feb 7, 2023
Merged

make dragvalue textedit style consistent with button #2649

merged 4 commits into from
Feb 7, 2023

Conversation

lictex
Copy link
Contributor

@lictex lictex commented Jan 30, 2023

  • use the same alignment as button in textedit
  • expand width to fit texts instead of clipping

2023-01-30-16-15-42

@lictex lictex marked this pull request as ready for review January 30, 2023 08:33
emilk
emilk reviewed Feb 4, 2023
View reviewed changes
crates/egui/src/widgets/text_edit/builder.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/drag_value.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/text_edit/builder.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/text_edit/builder.rs Outdated Show resolved Hide resolved
@lictex lictex marked this pull request as draft February 6, 2023 15:44
@lictex
* apply button_padding to textedit
7d75e4c 
* support vertical align
* add same min size as button to avoid unintented height shrink
@lictex lictex marked this pull request as ready for review February 6, 2023 16:36
emilk
emilk approved these changes Feb 7, 2023
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; works great!

@emilk emilk merged commit 8bc88c9 into emilk:master Feb 7, 2023
@lictex lictex deleted the dragvalue_style branch February 7, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lictex @emilk