Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add <algorithm> #2

Merged
merged 1 commit into from Jul 12, 2018

Conversation

Projects
None yet
2 participants
@m0ppers
Copy link
Contributor

commented Jul 11, 2018

otherwise it will not compile using MSVC for me. and checking with
cppreference I don't really understand why it works using clang the way it is right now:

https://en.cppreference.com/w/cpp/algorithm/max

also thanks for providing this sw renderer. it is super awesome :D

add <algorithm>
otherwise it will not compile using MSVC for me. and checking with
cppreference I don't really understand why it works using clang:

https://en.cppreference.com/w/cpp/algorithm/max
@m0ppers

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2018

some errors msvc is throwing (dozens of those):

error C2039: "max": Is not an element of "std"
error C3861: "max": identifier not found

@emilk

This comment has been minimized.

Copy link
Owner

commented Jul 12, 2018

Nice, thank you!

@emilk emilk merged commit b5ae63a into emilk:master Jul 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.