New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes scala code testable with sbt and adds minimal readme. #32

Merged
merged 1 commit into from Jul 28, 2017

Conversation

Projects
None yet
2 participants
@yannick-cw

Without "com.novocode" % "junit-interface" % "0.11" % "test->default"
sbt test does not run the jUnit tests in the scala repo.

I suggest adding junit-interface, as sbt test is the standard way to run tests with scala :)

Also I would be open to redo the tests a little bit, to be more scala like, if this is wanted ;)

@emilybache

This comment has been minimized.

Show comment
Hide comment
@emilybache

emilybache Jul 28, 2017

Owner

Thankyou for these changes. I'd be happy to receive a more scala-like first test too if you felt inspired to make one.

Owner

emilybache commented Jul 28, 2017

Thankyou for these changes. I'd be happy to receive a more scala-like first test too if you felt inspired to make one.

@emilybache emilybache merged commit 9e77f4f into emilybache:master Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment