Permalink
Switch branches/tags
Nothing to show
Commits on Sep 1, 2009
  1. Allow end-of-paragraph links on BLIP_SUBMITTED

    emk committed Sep 1, 2009
    Once the blip has been submitted, we can turn off our kludge that helps
    avoid annotating the current insertion point.  This was on my to-do
    list, and it was also suggested by Helge Jensen.
  2. checkstyle: Allow longer function bodies

    emk committed Sep 1, 2009
    Apparently, checkstyle counts large block comments towards the length of
    a function, so let's leave some room for mini-essays. :-)
Commits on Aug 31, 2009
  1. AdminView: Extract string constants, and fix URL-saving bug

    emk committed Aug 31, 2009
    Extracting the string constants from this class makes things feel a bit
    tidier.  This patch also fixes the BUG_URL_FIELD, which had an ID clash
    with the BUG_URL_LABEL in the last patch (due to an unsuccessful
    experiment).
  2. Move administrative code into new AdminView class

    emk committed Aug 31, 2009
    This keeps our main servlet clean.  This organization was inspired by
    Polly the Pollster.
  3. Load bug URL from metadata if already present

    emk committed Aug 31, 2009
    When creating the administration pane, we used to always default to the
    wave bug tracker URL, even if we already had a different URL in our
    metadata.  This could happen when buglinky had been removed from a wave
    and added back again.
  4. Make "#" optional in "issue #NNN"

    emk committed Aug 31, 2009
    I occasionally type this without the issue number.  Let's see how this
    works out in practice.
  5. Allow bug URL to be configured using form

    emk committed Aug 31, 2009
    This code is heavily inspired by Polly the Pollster, although we do
    respond to FORM_BUTTON_CLICKED instead of listening to form update
    events in real time.
    
    We slip in two semi-unrelated changes in this patch:
      1) We now listen for BLIP_SUBMITTED.
      2) We include an explanation of end-of-line behavior in our
         instructions.
  6. Add githib URL to profile

    emk committed Aug 31, 2009
Commits on Aug 30, 2009
  1. Extract blips from bundles in BlipProcessor

    emk committed Aug 30, 2009
    This functionality is reusable, so let's move it into a library class.
  2. Rename BugLinkAnnotator -> BugNumberLinker

    emk committed Aug 30, 2009
    This is a more specific and correct name.
  3. Add BugUrlReplacer to clean up bare URLs

    emk committed Aug 30, 2009
    This transformation was suggested by Brian Campbell.
  4. BugLinkAnnotator: Tidy up subclassing details

    emk committed Aug 30, 2009
    None of these changes make much difference, but they correspond better
    to the default styles used by Eclipse.
  5. Improve BlipProcessor documentation

    emk committed Aug 30, 2009
    This class is intended to be frequently subclassed, so let's improve the
    documentation.
  6. Compute wave address and profile name from app name

    emk committed Aug 30, 2009
    Let's not force people to change this in any more places than necessary.
  7. Rename Annotator -> BlipProcessor

    emk committed Aug 30, 2009
    We also want to support editing operations.
  8. Rename maybeAnnotate -> annotate

    emk committed Aug 30, 2009
    Whether or not we actually generate an annotation is an implementation
    detail.
  9. README.markdown: Do not start line with "#"

    emk committed Aug 30, 2009
    Lines starting with # cause markdown to format the README incorrectly.
  10. Match a wider variety of bug numbers

    emk committed Aug 30, 2009
  11. Move regex kludge from BugLinkAnnotator -> Annotator

    emk committed Aug 30, 2009
    This kludge really should be part of the abstract class, so that other
    subclasses will eventually be able to reuse it.
  12. Factor annotation code out into separate classes

    emk committed Aug 30, 2009
    This will eventually make it easier to have more than one annotator.
  13. README.markdown: Escape XML tags

    emk committed Aug 30, 2009
  14. README.markdown: Fix link syntax

    emk committed Aug 30, 2009
  15. Add a README file for github

    emk committed Aug 30, 2009
Commits on Aug 29, 2009
  1. Add Apache 2.0 license notices to the files

    emk committed Aug 29, 2009
    Note that this means this code may be used in GPLv3 projects, but not in
    GPLv2 projects.
  2. Allow existing annotation to be larger than the current one

    emk committed Aug 29, 2009
    When detecting whether an annotation already exists, accept any
    annotation with the correct name and value which includes at least the
    desired range. In this case, adding a new annotation does nothing except
    for generate useless network traffic.
  3. Fix warnings found by checkstyle

    emk committed Aug 29, 2009
  4. Configure checkstyle for use with project

    emk committed Aug 29, 2009
    One cascading update caused by using '==' instead of 'equals' is enough.
    Let's turn on some real warnings.
  5. Bug: Use equals() to compare, not ==

    emk committed Aug 29, 2009
    Buglinky had started spamming the bug tracker massively again, because
    it wasn't correctly identifying its own events.  Yeah, this was just a
    dumb Java comparison bug on my part.
  6. Refactor code for adding annotations

    emk committed Aug 29, 2009
  7. Filter events generated by this bot

    emk committed Aug 29, 2009