-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to latest versions #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! I've been hoping to get to this for a long time, and I appreciate it you tackling it. (And I'm sorry it has taken me so long to get back to you.)
Glancing quickly as the PR, here's a couple of important things that I noticed.
error-chain = "0.12" | ||
lazy_static = "1.4" | ||
log = "0.4" | ||
regex = "1.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For dependencies with versions 1 and above, we could specify just a major version. In this case, Cargo can pick up a package with this major version and any minor/patch version. It is because minor version changes shouldn't make incompatible API modification. See semver.org.
Thank you for the PR! I implemented this myself when updating to Rust 2018. |
I have updated dependencies to use ">=" requirements. Also, use Rust 2018 edition