Skip to content
Browse files

Fix contrib/hooks/post-receive-email for new duplicate branch

In the show_new_revisions function, the original code:

  git rev-parse --not --branches | grep -v $(git rev-parse $refname) |

isn't quite right since one can create a new branch and push it
without any new commits.  In that case, two refs will have the same
sha1 but both would get filtered by the 'grep'.  In the end, we'll
show ALL the history which is not what we want.  Instead, we should
list the branches by name and remove the branch being updated and THEN
pass that list through rev-parse.

Revised as suggested by Jakub Narebski and Junio C Hamano to use
git-for-each-ref instead of git-branch.  (Thanks!)

Signed-off-by: Pat Notz <>
Signed-off-by: Junio C Hamano <>
  • Loading branch information...
1 parent 7b73d82 commit e5f5050ed1481c3bc27658f625a87155aed0984f Pat Notz committed with gitster
Showing with 3 additions and 1 deletion.
  1. +3 −1 contrib/hooks/post-receive-email
4 contrib/hooks/post-receive-email
@@ -615,7 +615,9 @@ show_new_revisions()
- git rev-parse --not --branches | grep -v $(git rev-parse $refname) |
+ other_branches=$(git for-each-ref --format='%(refname)' refs/heads/ |
+ grep -F -v $refname)
+ git rev-parse --not $other_branches |
if [ -z "$custom_showrev" ]
git rev-list --pretty --stdin $revspec

0 comments on commit e5f5050

Please sign in to comment.
Something went wrong with that request. Please try again.