PIC: Masks - #7
Closed
mkroening wants to merge 2 commits into
Closed
Conversation
Owner
|
Thank you! This looks great. I'll try to merge it this weekend. |
Contributor
|
@emk Friendly ping :). |
|
Let's politely ping here again 🙂 |
|
@emk Your friendly neighborhood ping. |
phil-opp
added a commit
to rust-osdev/pic8259
that referenced
this pull request
May 17, 2021
Merges pull request emk/toyos-rs#7.
Contributor
|
Since this project appears to be abandoned, I created a fork of the |
This was referenced May 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #4.
This approach for adding support for interrupt masking adds methods to read and write both masks. I also added a function to disable the PIC by masking all interrupts.
What do you think?