Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: limit the number of cached files checked for existence #1153

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jun 11, 2024

No description provided.

@emmercm emmercm self-assigned this Jun 11, 2024
@emmercm emmercm enabled auto-merge (squash) June 11, 2024 01:23
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.20%. Comparing base (073a975) to head (fe37f7c).

Files Patch % Lines
src/types/files/fileCache.ts 66.66% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1153   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         102      102           
  Lines        6371     6373    +2     
  Branches     1508     1409   -99     
=======================================
+ Hits         5938     5940    +2     
- Misses        410      432   +22     
+ Partials       23        1   -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/limit-file-cache-checks" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm merged commit 860a9d2 into main Jun 11, 2024
53 of 54 checks passed
@emmercm emmercm deleted the emmercm/limit-file-cache-checks branch June 11, 2024 01:41
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant