Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: log token replacement errors at TRACE instead of WARN #1159

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jun 13, 2024

No description provided.

@emmercm emmercm self-assigned this Jun 13, 2024
@emmercm emmercm enabled auto-merge (squash) June 13, 2024 23:02
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.07%. Comparing base (72b1757) to head (8f97570).

Files Patch % Lines
src/modules/candidateGenerator.ts 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1159      +/-   ##
==========================================
- Coverage   93.11%   93.07%   -0.05%     
==========================================
  Files         102      102              
  Lines        6376     6381       +5     
  Branches     1410     1517     +107     
==========================================
+ Hits         5937     5939       +2     
+ Misses        438      419      -19     
- Partials        1       23      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/quiet-token-errors" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm merged commit d4db60a into main Jun 13, 2024
55 checks passed
@emmercm emmercm deleted the emmercm/quiet-token-errors branch June 13, 2024 23:08
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant