fix #396. Raise error when there is no matching quote. #477

Merged
merged 1 commit into from Dec 15, 2016

Projects

None yet

2 participants

@rebornix
Contributor

While troubleshooting issue Microsoft/vscode#17166 for VS Code, we found the trigger is running expandAbbreviation on a css rule without a closing quote, for example as below

.foo { 
  font-family: 'Segoe UI, Tahoma, Geneva, Verdana, sans-serif;
}

The root cause is that we don't quit the while loop while parsing quotes. We are handling brackets correctly, here this change is just aligning with other parts.

@sergeche sergeche merged commit 4fad992 into emmetio:master Dec 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sergeche
Member

Thanks!

@sergeche
Member

Published as v1.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment