New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for issue3 #10

Merged
merged 1 commit into from Aug 4, 2014

Conversation

Projects
None yet
3 participants
@junichi11
Collaborator

junichi11 commented Oct 9, 2013

Proposal for #3
I moved NbDocument.runAtomic into EmmetEditor.
Unfortunately, Undo/Redo behavior is changed.
e.g.
(old) ul+ (expand) -><ul><li></li></ul> -> undo ul+
(new) ul+ (expand) -><ul><li></li></ul> -> undo (empty) -> undo ul+

I'm sorry if I'm wrong.

Thanks.

@markiewb

This comment has been minimized.

Show comment
Hide comment
@markiewb

markiewb Oct 9, 2013

I have the same issue in my plugin markiewb/eclipsecodeformatter_for_netbeans#18
And no solution yet

I also remove and then insert into the document

                    document.remove(0, length);
                    document.insertString(0, result, null);
                    if (editor != null) {
                        editor.setCaretPosition(Math.max(0, Math.min(caret, document.getLength())));
                    }

https://github.com/markiewb/eclipsecodeformatter_for_netbeans/blob/master/src/de/markiewb/netbeans/plugins/eclipse/formatter/EclipseFormatterUtilities.java

markiewb commented Oct 9, 2013

I have the same issue in my plugin markiewb/eclipsecodeformatter_for_netbeans#18
And no solution yet

I also remove and then insert into the document

                    document.remove(0, length);
                    document.insertString(0, result, null);
                    if (editor != null) {
                        editor.setCaretPosition(Math.max(0, Math.min(caret, document.getLength())));
                    }

https://github.com/markiewb/eclipsecodeformatter_for_netbeans/blob/master/src/de/markiewb/netbeans/plugins/eclipse/formatter/EclipseFormatterUtilities.java

@junichi11

This comment has been minimized.

Show comment
Hide comment
@junichi11

junichi11 Oct 9, 2013

Collaborator

Oh..., I see. This proposal might not be helpful.

Collaborator

junichi11 commented Oct 9, 2013

Oh..., I see. This proposal might not be helpful.

@junichi11

This comment has been minimized.

Show comment
Hide comment
@junichi11

junichi11 Oct 9, 2013

Collaborator

@markiewb I misunderstood. I thought that the issue means "freeze".

Collaborator

junichi11 commented Oct 9, 2013

@markiewb I misunderstood. I thought that the issue means "freeze".

@markiewb

This comment has been minimized.

Show comment
Hide comment
@markiewb

markiewb Oct 9, 2013

@junichi11 : No. RunAtomic works as expected. Thanks again.

markiewb commented Oct 9, 2013

@junichi11 : No. RunAtomic works as expected. Thanks again.

sergeche added a commit that referenced this pull request Aug 4, 2014

@sergeche sergeche merged commit bc90921 into emmetio:master Aug 4, 2014

@junichi11 junichi11 deleted the junichi11:patch-3 branch Sep 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment