Detect os in build.gradle, add error reportrer #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice1000
commented
Aug 16, 2018
| private object AnonymousFeedback { | ||
| private const val tokenFile = "de/halirutan/mathematica/errorreporting-emmylua/token.bin" | ||
| private const val gitRepoUser = "EmmyLua" | ||
| private const val gitRepo = "IntelliJ-EmmyLua" |
There was a problem hiding this comment.
@tangzx Change repo user and name
tangzx
reviewed
Aug 16, 2018
| "error.hash" to error.exceptionHash) | ||
| for (attachment in error.attachments) { | ||
| params["attachment.name"] = attachment.name | ||
| params["attachment.value"] = attachment.encodedBytes |
|
我错了，我本地不小心push到origin了。。 |
ice1000
commented
Aug 16, 2018
| val params = mutableMapOf( | ||
| "error.description" to error.description, | ||
| // TODO | ||
| // "Lua Version" to (project?.run { /* get lua sdk version here */ } ?: "Unknown"), |
There was a problem hiding this comment.
阿唐你看要不要在这里加点获取当前信息的代码 @tangzx
There was a problem hiding this comment.
我觉得可以把Lua的SDK信息也放进来啊，这样你好调试什么的
There was a problem hiding this comment.
。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.