New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emojify.run("that'd") == that':D #36

Closed
qq99 opened this Issue Jun 22, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@qq99
Contributor

qq99 commented Jun 22, 2014

emojify.run("that'd") == that':D
=> that':smile:

that'd may not be grammatical, but it should not be emojified :P

@qq99 qq99 changed the title from emojify.run("that'd") == ':D to emojify.run("that'd") == that':D Jun 22, 2014

@hassankhan hassankhan added the bug label Jun 23, 2014

@hassankhan

This comment has been minimized.

Show comment
Hide comment
@hassankhan

hassankhan Jun 23, 2014

Member

That's weird, I'll try and have a look later this week.

Member

hassankhan commented Jun 23, 2014

That's weird, I'll try and have a look later this week.

@scripting

This comment has been minimized.

Show comment
Hide comment
@scripting

scripting Jul 1, 2014

We're also having x-d rendered as an Emoji.

See this blog post for details.

http://virgin.smallpict.com/2014/07/01/sixdigit.html

We're using Emojify in Fargo.

Dave

We're also having x-d rendered as an Emoji.

See this blog post for details.

http://virgin.smallpict.com/2014/07/01/sixdigit.html

We're using Emojify in Fargo.

Dave

@qq99

This comment has been minimized.

Show comment
Hide comment
@qq99

qq99 Jul 13, 2014

Contributor

@scripting my PR here #35 suggests that your issue should be fixed, are you sure you're using a more recent version of emojifyjs?

Contributor

qq99 commented Jul 13, 2014

@scripting my PR here #35 suggests that your issue should be fixed, are you sure you're using a more recent version of emojifyjs?

@qq99

This comment has been minimized.

Show comment
Hide comment
@qq99

qq99 Jul 13, 2014

Contributor

I've found out why my issue is occuring, and am working on a PR to prevent it.
Basically, I was trying to emojify the string I'd (the HTML escaped version of I'd), and it's matching the ;d

Contributor

qq99 commented Jul 13, 2014

I've found out why my issue is occuring, and am working on a PR to prevent it.
Basically, I was trying to emojify the string I'd (the HTML escaped version of I'd), and it's matching the ;d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment