New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji Keyboard (2016) by EmojiOne Chrome extension mangles hidden text on Wikipedia pages using the `{{val}}` template #549

Open
SnoopJeDi opened this Issue Sep 19, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@SnoopJeDi

SnoopJeDi commented Sep 19, 2017

Apologies if this report is in the wrong place, I can't find any information for the Chrome extension for reporting bugs on GitHub.

As described on Wikipedia, the {{val}} template, which depends on Module:Convert, uses a ♠ character to separate keys used for sorting values from display values. I noticed this on a page using {{val}}, where the EmojiOne plugin for Chrome picks up this character and replaces it. This has two bad side effects:

  1. A spurious ♠ is displayed in the actual text of the article. Very confusing!
  2. Sorting will presumably no longer work at all, because the sortkey is being destroyed by the plugin's replacement.

I don't think there's any clean way around this, but it impacts more than 6000 articles on Wikipedia, so I think it's worth mentioning.

The only solution I can think of is to ignore <span> elements with the sortkey class set for Wikipedia (and other Wiki sites?) domains.

@DanieleTorino

This comment has been minimized.

DanieleTorino commented Nov 28, 2017

The only solution I can think of is to ignore elements with the sortkey class set for Wikipedia (and other Wiki sites?) domains.

The span in question has the style attribute set to display:none. Ignoring all spans with class sortkey does not seem a clean solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment