Merge master to stable #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TrystanLea
commented
Jan 22, 2020
TrystanLea
commented
- remove openevse app - as same as myelectric2
- fix feed selection to allow feeds with same name but different tags
- fix tablet css to resize graph in portrait mode
- add extra check for empty data
- added caching param to list.json requests
- Fix: mysolarpv graph not correctly updated
tested for js errors and caught errors
In my setup the solar feed only gets updates if there is a change on the PV output. This means during daytime the solar feed constantly gets updates. But during night time there is no update as the output stays at 0 all the time. With that setup the graph of the MySolarPv app is correctly updated during day time. But during night time there is no update on both use and solar. Both graphs show 0 at the end. When the graph is reloaded by a browser refresh then the use graph is correctly shown. The reason for this is that the time of the last update on the solar feed is used to update both the solar and the use timeseries. If this is changed so that the timeseries are updated with the max time of both feeds then the use graph is correctly updated also if there is no change on the solar feed.
Fix: mysolarpv graph not correctly updated.
This occurs when connection to the server breaks
fix tablet css to resize graph in portrait mode
Add extra check for empty data
added caching param to list.json requests
stopped crashing errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.