Initial changes to remove hardcoded paths #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task is to make the backup module work on non pi systems. I have modified this so that the config file now resides in the php folder and is read by both the php side and the bash side. I am not sure if this is a security issue or not. I have also added in some file exist checks for non EmonPi setups. Phpfiwa was not backed up. This needs more development in identifying different base systems and reacting accordingly. feedwriter is not stopped currently (commented out) as I dot have it installed. The service could be checked for existing & running. As I say, just a start on this.
|
I've merged your pull request into a development branch called multienv for testing, I've fixed the conflicts and added some new work on UI layout to use a sidebar #23 |
|
PS: Thanks a lot for this pull request and sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task is to make the backup module work on non pi systems.
I have modified this so that the config file now resides in the php folder and is read by both the php side and the bash side. I am not sure if this is a security issue or not.
I have also added in some file exist checks for non EmonPi setups.
Phpfiwa was not backed up.
This now needs more development in identifying different base systems and reacting accordingly.
feedwriter is not stopped currently (commented out) as I don't have it installed. The service could be checked for existing & running.
As I say, just a start on this.