Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore the possibility of using feedname+tag in place of feedid #145

Closed
pb66 opened this issue Feb 27, 2018 · 3 comments
Closed

Explore the possibility of using feedname+tag in place of feedid #145

pb66 opened this issue Feb 27, 2018 · 3 comments

Comments

@pb66
Copy link
Contributor

pb66 commented Feb 27, 2018

See the https://community.openenergymonitor.org/t/copy-users-on-private-server-including-dashboard-inputs-feeds-graphs-etc/6673?u=pb66 forum thread.

Exclusive use of feedids makes replicating dashboards across accounts very difficult. An option to use Feedname+tag would allow similar functionality to the apps modules.

As pointed out by @TrystanLea, the use of feedids allows the changing feed names to not impact dashboard operation. So perhaps each widget or perhaps better, dashboard, could have a use feedid or use feedname(+tag) option switch.

The "+tag" is used in the device module as the same feednames can be used multiple time in any one account, so using a feedname+tag would allow a particular feed of any given name to be used, rather than feednames needing to be unique to the account, they only need to be unique to the tag.

@TrystanLea
Copy link
Member

I've had a go at making this work and have a good solution I think for the dial widget and visualisations https://github.com/emoncms/dashboard/tree/tagname_option.

The visualisations require these modifications in emoncms core:
https://github.com/emoncms/emoncms/compare/dashboard_tagname_support?expand=1

I havent finished going through every widget to add the conversion from tag:name to feedid support yet but this is an example of what is required for the dial widget:

https://github.com/emoncms/dashboard/compare/tagname_option?expand=1#diff-cb9b63498661098295e6314bfbc1cf25R553

The option to build a dashboard using tag:name or feedid is set in the dashboard configuration. On switching the feedmode from feedid to tag:name you still need to go through each widget in the dashboard and re-save its feed configuration.

@TrystanLea
Copy link
Member

I've been through the rest of the widgets in the dashboard and added the required tag:name to feedid conversion.

@TrystanLea
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants