-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add key bindings to move things around the dashboard editor #9
Add key bindings to move things around the dashboard editor #9
Conversation
|
I was about to comment on that!! |
|
It's still not happening for me, I have your latest version of designer.js and the arrow keys have no effect other than move the page up or down a little. |
|
@Paul-Reed - Hmm that's weird! I'm mainly using Chrome, but it also works for me in Safari. How odd! I'm using a Mac, but I can't believe that would make a difference here. Unless the key code is different for the arrow keys... What does this website say when you press the arrow keys on your keyboard? |
|
37, 38, 39 & 40, identical to your commit. |
|
@Paul-Reed - can you try with that latest commit please? I switched it to binding through jquery which may standardise things across browsers/OSes for us. |
|
The jquery switch on your last commit has now enabled the arrow keys. and appear to be now working as intended. Great! |
|
Yeh, I found this incredibly useful. Moving things around by dragging the centre is rather frustrating especially when the centre isn't very visible (thus hard to find) due to the colour of the widget. |
|
Thanks Matt, works fine now provided the cache is refreshed to clear the javascript. No errors, and no detrimental issues for android/ios. |
|
Matt, one thing that I have found; Paul |
|
Ah yes. That'll need fixing. Good spot. I'll work on that ASAP. I've always wondered why the page isn't infinite anyway, and just scroll as far as is needed to view every element. But maybe there's a reason why that is hard to implement.
|
|
@Paul-Reed - fixed with #10. |
This adds key bindings when on the dashboard editor so that you can move items around with the arrow keys. Items move by 1 grid size unit in whichever direction of arrow you press.