Invalid Serial Port type on update

[borpin]

The code does not allow for not using a serial port.

Please fix urgently @TrystanLea.

emoncms/Modules/admin/admin_controller.php

Line 237 in a7ddc33

if (!in_array($serial_port,array("ttyAMA0","ttyUSB0","ttyUSB1","ttyUSB2"))) return "Invalid serial port type";

The port variable is null - note I am only doing an emoncms update.

[TrystanLea]

Thanks @borpin

Does this exit the update process? What are you seeing exactly?

[borpin]

Does this exit the update process? What are you seeing exactly?

Yes it just bombs out with that message which is never actually written to the log file either.

Note I am trying to only update emoncms at this point, and the admin does say none next to firmware.

Anyone who hits this will have to manually update via git to clear this code going forward.

[TrystanLea]

Ok I can see the issue, thanks

[TrystanLea]

Clicked the wrong button there!