Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable envvars to be used #1467

Merged
merged 1 commit into from Nov 26, 2019
Merged

Enable envvars to be used #1467

merged 1 commit into from Nov 26, 2019

Conversation

@borpin
Copy link
Contributor

borpin commented Oct 25, 2019

Update code to enable Envvars to be specified in the settings.ini

Needs testing!!!!!!

Discussion in #1452 refers

Update code to enable Envvars to be specified in the settings.ini
@relnah

This comment has been minimized.

Copy link

relnah commented Oct 25, 2019

Disregard my last comment, I deleted it.
Seems to work.
Using this settings.ini (chopped upp the password just to try two envvars with static characters mixed in)

[sql]
server = {{MYSQL_HOST}}
username = {{MYSQL_USER}}
password = {{MYSQL_PASSWORD1}}1{{MYSQL_PASSWORD2}}

[redis]
enabled = {{REDIS}}

[mqtt]
enabled = false

[log]
level = {{LOG_LEVEL}}
@borpin

This comment has been minimized.

Copy link
Contributor Author

borpin commented Oct 25, 2019

Seems to work.

Great, thanks.

For formatting code blocks, use 3 backticks on a line before and 3 on a line after. The single backticks just work within a single line (no CR).

Cheers

@TrystanLea TrystanLea merged commit 5b898b6 into emoncms:master Nov 26, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TrystanLea

This comment has been minimized.

Copy link
Member

TrystanLea commented Nov 26, 2019

Thanks @borpin @relnah, finally tested here both using the emoncms-docker and a standard image, working well, merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.