hierarchy of object-based modules framework #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New custom emoncms module class. Each module should inherit from custom module. Added input and feed class modules User view shows installed modules
Conflicts: index.php
…class The module dont need to know the menu variable where get connected Menu names in classes allows get translation in his own localization file
Faster using singleton pattern for registered modules
Delete emoncms modules constructors (not yet needed)
… behaviour The registratio of module is made only when is needed due the singleton pattern
TrystanLea
pushed a commit
that referenced
this pull request
Nov 9, 2015
vkylamba
pushed a commit
to vkylamba/emoncms
that referenced
this pull request
Mar 17, 2017
Master GitHub
vkylamba
pushed a commit
to vkylamba/emoncms
that referenced
this pull request
Mar 18, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New custom emoncms module class. Each module should inherit from custom module.
Added input and feed class modules
Admin view shows installed modules
TODO: build menu from module object information (we could have not visible modules)(not necesary in settings to set and know the modules) --->>>> DONE
The menu is build from information from each module object so emocms dont have to know more information (modules abstraction)
The module load/registration logic is moved to a class to encapsulate behaviour
The registration of module is made only when is needed due the singleton pattern
Updated to Twitter Bootstrap 2.1.0
:-)