Update feed_model.php #517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added line 456 to mitigate divide by 0 errors; This is *NOT* the correct way to fix this issue, this is a reference only to help some of you understand where the issue is. I have not worked out yet where the variable $outinterval is supposed to be populated from, but at this point in the code its either null or 0 - and this un turn causes the divide by 0 errors. My code simply detects when $outinterval is less than 1 and sets this variable to 1 before its used. (on line 457 in this version). Applying my code appears to fix the connection issues with the android app, fixing the divide by zero cleaned that right up, but my fix may have other consequences (although quite unlikely).
|
This issue that caused the connection issues with the Android app has been fixed with an update to the Android app 1.2.2: https://community.openenergymonitor.org/t/android-app-connection-error/250/8 However I will keep this open for @TrystanLea to take a look |
Add CSS to "Copy API Key" buttons, text labels shortened to keep the look consistent.
|
This latest commit is nothing to do with the first one, I'm going to close the PR and make a new one for the latest commit - the changes to feed_model.php were easy enough to find that I could do so again anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added line 456 to mitigate divide by 0 errors;
This is NOT the correct way to fix this issue, this is a reference only to help some of you understand where the issue is.
I have not worked out yet where the variable $outinterval is supposed to be populated from, but at this point in the code its either null or 0 - and this un turn causes the divide by 0 errors.
My code simply detects when $outinterval is less than 1 and sets this variable to 1 before its used. (on line 457 in this version).
Applying my code appears to fix the connection issues with the android app, fixing the divide by zero cleaned that right up, but my fix may have other consequences (although quite unlikely).