Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dropdowns a maximum height and allow them to scroll #571

Merged
merged 1 commit into from
Oct 11, 2016

Conversation

mattjgalloway
Copy link
Contributor

This aids usability when you have a long list of items. Moving your mouse all the way down can be tedious. Scrolling the list is easier.

In particular this is useful when you have a long list of dashboards which ends up going off the screen. Now it'll scroll so you can get to all of the items. This was picked up here:
https://community.openenergymonitor.org/t/dashboard-menu-does-not-scroll-not-all-dashboards-accessible-from-it

This aids usability when you have a long list of items. Moving your mouse all the way down can be tedious. Scrolling the list is easier.

In particular this is useful when you have a long list of dashboards which ends up going off the screen. Now it'll scroll so you can get to all of the items. This was picked up here:
https://community.openenergymonitor.org/t/dashboard-menu-does-not-scroll-not-all-dashboards-accessible-from-it
@Paul-Reed
Copy link
Member

Matt looking through your code, I'm assuming that these change will equally apply to the other dropdown menus, such as 'Apps' or 'Extras' (should their number of items increase!!), so there will be some future consistency on the menu bar.

Paul

@mattjgalloway
Copy link
Contributor Author

That's right.

@Paul-Reed
Copy link
Member

Thanks Matt, makes life easier especially when trying to access a long list on a small screen. I've also spoken with Willems (joyrider3774) who also finds the fix of benefit.

Paul

@Paul-Reed Paul-Reed merged commit 044693a into emoncms:master Oct 11, 2016
@mattjgalloway mattjgalloway deleted the menu_scroll branch October 11, 2016 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants