Mqtt input json #801
Merged
Mqtt input json #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified phpmqtt_input to accept a validated JSON name:value object. TODO - look for a 'time' name, put it into $time and remove from JSON object. TODO - update comments .gitnore updated to ignore VSCode setting folder.
A problem was found in that emoncms does not handle non numeric dates in the past elsewhere. This converts the date to a number of seconds.
suggestion to use in-built processing rather than input methods
Make the searching for a 'time' key case insensitive and add in some additional logging.
make time key case insensitive and add logging
Wrong variable used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @TrystanLea can this be merged into the master branch? Hope I've not done something wrong here...