Modify time validation for API and MQTT input #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate the time input value for both the API (less bulk input) and MQTT input, to allow time to be in ISO string and seconds. Updated validation of time input to MQTT to make more robust. Used same method in input_mthods so both input methods allow same time format. Updated API help page. Not tested any impact to bulk upload method. Should be none.
|
Can this be merged @TrystanLea ? |
This was referenced Jul 3, 2018
|
Thankyou @borpin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #777 and a replacement PR for #804.
Validate the time input value for both the API (less bulk input) and MQTT input, to allow time to be in ISO string and seconds.
Updated validation of time input to MQTT to make more robust. Used same method in input_mthods so both input methods allow same time format.
Updated API help page.
Not tested any impact to bulk upload method. Should be none.