Feature/issue 655 clear all old feed data #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPUnit tested - added feed engine test for PHPFina added 2 new methods to the engine interface
…m:emrysr/emoncms into feature/issue-655-clear-all-old-feed-data
hidden shift() - not a part of the issue - only used to shift test data to new start_time
|
I've added the column "Days" column during testing and didn't remember to remove it... I can remove the column from this pr and create a new one with that feature if required. |
|
Now shows success/error message in modal overlay once clear() or trim() is called.
|
added unavailable message clear() & trim() methods to other engines
|
@TrystanLea
|
|
Fantastic! thanks @emrysr! really appreciate all the work you've put into this one |
|
added another feature to the feed trim form relative date selection buttons |
|
Hi. How do I get this option ? I am running 10.1.3 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #655
also fixes: #878
this allows for clearing all feed data and "trimming" data up to a given date
column marked yellow = clear
column marked green = trim
NOT YET TESTED ON A EMONPI.