Fix cookie path restriction when running on domain root #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emrysr
approved these changes
Jul 25, 2018
There was a problem hiding this comment.
@TrystanLea - I've seen this error while running the docker image and this pr fixes the issue. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#918 introduced a fix for cookies so that if emoncms is running at e.g. domain.net/emoncms, then cookies it saves would be restricted to that path and below. However it also broke logins if Emon is running not in a subdirectory because it set a restriction to the path
//rather than/. This pull request fixes that behaviour.