Graph module dependency on the config module for vue.js?

[pb66]

Shouldn't vue.js be moved to the main emoncms repo if multiple modules depend on it?

graph/view.php

Line 50 in 866bd60

<script src="<?php echo $path; ?>Modules/config/vue.js"></script>

This is the error message displayed when navigating to the graph page (or refreshing it) if the config module is not installed.

[borpin]

Someone else caught out by this https://community.openenergymonitor.org/t/vue-not-defined/11804

[emrysr]

the vuejs file was available in the Lib directory. I hadn't linked to the correct file. fixed in pull #103

[borpin]

I've just pulled this and I'm still getting the same error. Checked cache and restarted webserver.

[emrysr]

hi @borpin,
I'd changed the source of the javascript to an existing file in the emoncms repo (3 months old):
https://github.com/emrysr/emoncms/blob/master/Lib/vue.min.js

If you use this domain http://localhost/emoncms you should be able to see it with this link...
http://localhost/emoncms/Lib/vue.min.js

Can you see the file?

[screenshot of paths used in the html source]

[borpin]

Ah, sorry, the PR has not been merged has it?

[emrysr]

no yet.
you could test it with this:

git checkout -b emrysr-fix/issue-102-vue-device-dependency master
git pull https://github.com/emrysr/graph.git fix/issue-102-vue-device-dependency

not a major change. should work universally

[borpin]

Yep that fixes it :)