Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check return value of eredis_cluster #187

Merged
merged 3 commits into from Dec 7, 2020
Merged

check return value of eredis_cluster #187

merged 3 commits into from Dec 7, 2020

Conversation

6293
Copy link
Contributor

@6293 6293 commented Dec 7, 2020 •
edited

@6293 6293 mentioned this pull request Dec 7, 2020
Merged
@6293 6293 requested review from HJianBo and zmstone December 7, 2020 05:55
HJianBo
HJianBo approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@HJianBo HJianBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try to upgrade the emqtt deps to 1.2.3? It may help CI checks

@6293 6293 requested a review from HJianBo December 7, 2020 09:55
@HJianBo HJianBo marked this pull request as draft December 7, 2020 10:20
@HJianBo HJianBo added the bug label Dec 7, 2020
@HJianBo HJianBo added this to the 4.2.4 milestone Dec 7, 2020
@HJianBo HJianBo marked this pull request as ready for review December 7, 2020 10:35
@HJianBo HJianBo merged commit 99d17b3 into emqx:dev/v4.2.4 Dec 7, 2020
@6293 6293 mentioned this pull request Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmstone zmstone Awaiting requested review from zmstone

@HJianBo HJianBo Awaiting requested review from HJianBo

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.2.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@6293 @HJianBo