Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default application secret #58

merged 8 commits into from Mar 12, 2019


Copy link

HJianBo commented Mar 8, 2019

No description provided.

Prior to this change, travis-CI always run failed because the
init_per_suite function is not compatible with rebar and there are too
many undefined or unused functions in emqx_management.
This change fix these problems
case proplists:get_value(default_secret, AppConf) of
undefined -> emqx_guid:to_base62(emqx_guid:gen());
Secret when is_binary(Secret) -> Secret

This comment has been minimized.

Copy link

gilbertwong96 Mar 8, 2019


Please align code.

@HJianBo HJianBo force-pushed the feature_pr20 branch from e2f8192 to eba4b6a Mar 9, 2019
@HJianBo HJianBo self-assigned this Mar 9, 2019
Secret = emqx_guid:to_base62(emqx_guid:gen()),
add_app(AppId, Name, undefined, Desc, Status, Expired).

-spec(add_app(appid(), binary(), binary(), binary(), boolean(), integer() | undefined) -> {ok, appsecret()} | {error, term()}).

This comment has been minimized.

Copy link

gilbertwong96 Mar 11, 2019


fold this line

@terry-xiaoyu terry-xiaoyu merged commit 064f4c9 into develop Mar 12, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Travis CI - Pull Request Build Passed
@terry-xiaoyu terry-xiaoyu deleted the feature_pr20 branch Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.