Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change register-providers to load-providers #26

Merged
merged 1 commit into from Apr 18, 2019

Conversation

@terry-xiaoyu
Copy link
Contributor

terry-xiaoyu commented Apr 18, 2019

We used two-step procedure to load the providers:

  1. Let the plugin to register itself as a provider of rule-engine.
  2. Then rule-engine will search all available resource/action specs (the module attrs -resource_type and -rule_action) from the code of that plugin.

I am removing the first step, so all the resource/action specs will be loaded without startup the plugin. For resources/actions that need a supervisor tree (like mysql), we'll provide a top-level supervisor tree in the rule-engine.

We used two-step procedure to load the providers:

1. Let the plugin to register itself as a provider of rule-engine.
2. Then rule-engine will search all available resource/action specs (the module attrs -resource_type and -rule_action) from the code of that plugin.

I am removing the first step, so all the resource/action specs will be loaded without startup the plugin. For resources/actions that need a supervisor tree (like mysql), we'll provide a top-level supervisor tree in the rule-engine.
@terry-xiaoyu terry-xiaoyu merged commit af131ee into develop Apr 18, 2019
@terry-xiaoyu terry-xiaoyu deleted the load_providers branch Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.