Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix idle_timeout configuration #128

Merged
merged 5 commits into from Jun 19, 2019

Conversation

@tradingtrace
Copy link
Contributor

tradingtrace commented Jun 19, 2019

  1. It was ?IDLE_TIMEOUT in the return of idle state, but I think it should be #state.idle_timeout which comes from emqx_sn.conf.
  2. #state.idle_timeout was used by the stats collection timer, it's a little confusing. Add a macro ?STAT_TIMEOUT for it.
  3. Change shutdown to stop when idle timeout to ignore the prints in #110 which generated by the broadcast from emqx_sn itself.
turtleDeng and others added 5 commits May 27, 2019
Auto-pull-request-by-2019-05-27
Enlarge duration
@gilbertwong96 gilbertwong96 changed the base branch from master to develop Jun 19, 2019
@gilbertwong96

This comment has been minimized.

Copy link
Contributor

gilbertwong96 commented Jun 19, 2019

Thanks for your contribution and really appreciate your work 👍

@gilbertwong96 gilbertwong96 merged commit ef1141f into emqx:develop Jun 19, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.