New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a config file for testing #1794

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
3 participants
@spring2maz
Contributor

spring2maz commented Sep 6, 2018

Prior to this change, the template file etc/emqx.conf is used
directly in testing, as a result, mustache dir:s are created

In this change, Makefile steps are added to download bbmustach
and load the template input then replace with variableds defined
in 'vars' file, saved to etc/gen.emqx.conf for testing

@emqplus emqplus requested review from turtleDeng and emqplus Sep 7, 2018

@emqplus emqplus self-assigned this Sep 7, 2018

@emqplus emqplus added the Enhancement label Sep 7, 2018

@emqplus emqplus added this to the 3.0-beta.2 milestone Sep 7, 2018

@Gilbert-Wong Gilbert-Wong requested a review from huangdan Sep 7, 2018

Generate a config file for testing
Prior to this change, the template file etc/emqx.conf is used
directly in testing, as a result, mustache style directories
are created e.g. `{{ platform_log_dir }}` which should have been
replaced with a config varialbe e.g. `log`

In this change, Makefile targets are added as `ct` dependency
to download bbmustach, load the template input, replace with
variableds defined in 'vars' file, finally to etc/gen.emqx.conf.
The direct usage of etc/emqx.conf in test code are replaced with
gen.emqx.conf
@spring2maz

This comment has been minimized.

Contributor

spring2maz commented Sep 7, 2018

fixed typos and wording

@turtleDeng turtleDeng merged commit c0ddbba into emqx:emqx30 Sep 7, 2018

@spring2maz spring2maz deleted the spring2maz:generate-temp-config-for-test branch Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment