Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebar3 and erlang.mk dual support. #1806

Merged
merged 2 commits into from Sep 9, 2018

Conversation

@spring2maz
Copy link
Contributor

spring2maz commented Sep 9, 2018

There was only erlang.mk support prior to this change.
The main reasons for this dual support are:

  • Cover report upload can only be done by rebar3 in travis.ci
  • We want to prepare for the future to build emqx releases using rebar3
  • We do not want to stop supporting erlang.mk in one single step
@spring2maz spring2maz force-pushed the rebar3-erlang-mk-dual-support branch from 906d390 to a72146f Sep 9, 2018
@spring2maz spring2maz requested a review from terry-xiaoyu Sep 9, 2018
There was only erlang.mk support prior to this change.
The main reasons for this dual support are:
* Cover report upload can only be done by rebar3 in travis.ci
* We want to prepare for the future to build emqx releases using rebar3
* We do not want to stop supporting erlang.mk in one single step
@spring2maz spring2maz force-pushed the rebar3-erlang-mk-dual-support branch from a72146f to c96df4b Sep 9, 2018
@spring2maz spring2maz force-pushed the rebar3-erlang-mk-dual-support branch from a9ca79c to df9b85a Sep 9, 2018
@spring2maz

This comment has been minimized.

Copy link
Contributor Author

spring2maz commented Sep 9, 2018

@Gilbert-Wong Thanks for the review, made a minor change and squashed into the last commit.

Diff since last review:
Got rid of the intermediate dep-versions tmp file for make dep-vsn-check
Also changed clique's branch from fix-get-stacktrace-for-otp-21 to develop

@gilbertwong96 gilbertwong96 merged commit 0c39a76 into emqx30 Sep 9, 2018
@gilbertwong96

This comment has been minimized.

Copy link
Contributor

gilbertwong96 commented Sep 9, 2018

You are welcome. Thanks for your PR.

@spring2maz spring2maz deleted the rebar3-erlang-mk-dual-support branch Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.