Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Request & Response (broker and client) #1819
Prior to this change, there is no validate and specified process for Request-Response-Information and Response-Information
Prior to this change, there is no validation for response-topic which may cause unexpected error when broker is forwarding request response message.
Prior to this change, there are no test case for the new properties validation added after beta1 release. It is not a best practice.
Pull Request Test Coverage Report for Build 3600
Prior to this change, emqx directly catch validate exception which would try to retrieve the whole stacktrace. It would cost a lot of resources and slow down the whole broker. This change fix ths performance issue.
Prior to this change, if there are connect packets of mqtt 5.0 version and the packet is inconsistent with the connect packet as mqtt 5.0 specification, it would not deliver reason code back to client This change fix this bug
Prior to this change, there are serveral bugs in response&request realized in broker and the protocol test cases are really bad. This change fix the bugs and delete all the test cases in emqx_protocol_SUITE.erl, also add connect test cases for mqtt 4 and mqtt5.
Prior to this change, there are no macro for <<>> which would make code chaos and no monitor for client process. This change adds macros for <<>>, move export_type under export, add response_topic() type and delete duplicated exported types.
Prior to this change emqx_client:request APIs need to make several gen_statem calls in order to get the request/response topic prefix stored in client state data. This commit tries to: 1. make less gen_statem call to get topic prefix 2. move the gen_statem call to a separate call so make the topic construction functions side-effect free
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.