Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue#1833 and #1834 #1845

Merged
merged 5 commits into from Sep 22, 2018

Conversation

@tigercl
Copy link
Collaborator

tigercl commented Sep 21, 2018

tigercl added 2 commits Sep 21, 2018
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 21, 2018

Pull Request Test Coverage Report for Build 3326

  • 7 of 14 (50.0%) changed or added relevant lines in 2 files are covered.
  • 114 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.5%) to 55.534%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_session.erl 2 3 66.67%
src/emqx_protocol.erl 5 11 45.45%
Files with Coverage Reduction New Missed Lines %
src/emqx_gc.erl 2 91.67%
src/emqx_misc.erl 2 93.33%
src/emqx_connection.erl 41 56.34%
src/emqx_session.erl 69 68.34%
Totals Coverage Status
Change from base Build 3230: 0.5%
Covered Lines: 2298
Relevant Lines: 4138

💛 - Coveralls
@emqplus emqplus requested review from emqplus, spring2maz and turtleDeng and removed request for spring2maz Sep 21, 2018
src/emqx_session.erl Show resolved Hide resolved
@terry-xiaoyu terry-xiaoyu merged commit 03f607c into emqx30 Sep 22, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.5%) to 55.534%
Details
@terry-xiaoyu terry-xiaoyu deleted the issue#1833_1834 branch Sep 22, 2018
@huangdan huangdan added this to the 3.0-beta.3 milestone Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.