Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from customized total heap size check to set process flag #1855

Merged
merged 1 commit into from Sep 29, 2018

Conversation

@spring2maz
Copy link
Contributor

spring2maz commented Sep 22, 2018

The max_heap_size process flag can be used to limit total heap size of a process, and it gives much more detailed crash log if the limit is hit.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 22, 2018

Pull Request Test Coverage Report for Build 3345

  • 7 of 8 (87.5%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 55.286%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_misc.erl 5 6 83.33%
Totals Coverage Status
Change from base Build 3332: 0.03%
Covered Lines: 2301
Relevant Lines: 4162

💛 - Coveralls
@spring2maz spring2maz requested review from turtleDeng and emqplus Sep 22, 2018
@emqplus emqplus self-assigned this Sep 22, 2018
@emqplus emqplus added the Enhancement label Sep 22, 2018
@emqplus emqplus added this to the 3.0-beta.3 milestone Sep 22, 2018
@spring2maz spring2maz force-pushed the make-use-of-max-heap-size-process-flag branch from 84a9f90 to 49d93f8 Sep 22, 2018
@spring2maz

This comment has been minimized.

Copy link
Contributor Author

spring2maz commented Sep 22, 2018

rebased to resolve conflict.

The `max_heap_size` process flag can be used to limit total
heap size of a process, and it gives much more detailed
crash log if the limit is hit.
@spring2maz spring2maz force-pushed the make-use-of-max-heap-size-process-flag branch from 49d93f8 to 6f7ea6e Sep 22, 2018
@emqplus emqplus merged commit e3f2ae8 into emqx30 Sep 29, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 55.286%
Details
@spring2maz spring2maz deleted the make-use-of-max-heap-size-process-flag branch Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.