Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rebar3 xref work. #1861

merged 4 commits into from Sep 25, 2018


Copy link

spring2maz commented Sep 23, 2018

Fixed a bad call in emqx_mod_subscription module
also commented out dead code for now in emqx_config.erl

Fixed a bad call in emqx_mod_subscription module
also commented out dead code for now in emqx_config.erl
@spring2maz spring2maz requested review from turtleDeng and emqplus Sep 23, 2018
spring2maz added 3 commits Sep 23, 2018
This is done by moving coveralls send to after_success section
in .travis.yml.
having it in after_success should not make the build fail if
coveralls send fails due to server being overloaded etc.
@spring2maz spring2maz force-pushed the fix-xref-check branch from 5d4c859 to 9d33901 Sep 23, 2018

This comment has been minimized.

Copy link

coveralls commented Sep 23, 2018

Pull Request Test Coverage Report for Build 3366

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 56.704%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_mod_subscription.erl 0 1 0.0%
src/emqx_config.erl 0 5 0.0%
Totals Coverage Status
Change from base Build 3354: 0.3%
Covered Lines: 2360
Relevant Lines: 4162

💛 - Coveralls
@emqplus emqplus self-assigned this Sep 25, 2018
@emqplus emqplus added the Enhancement label Sep 25, 2018
@emqplus emqplus added this to the 3.0-beta.4 milestone Sep 25, 2018
@emqplus emqplus merged commit c123064 into emqx30 Sep 25, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
coverage/coveralls Coverage increased (+0.3%) to 56.704%
@emqplus emqplus deleted the fix-xref-check branch Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.