Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared subscriber should be keyed by group ID #1871

Merged
merged 1 commit into from Sep 28, 2018

Conversation

@spring2maz
Copy link
Contributor

spring2maz commented Sep 27, 2018

Prior to this change, if a producer session produces to two
or more shared subscriber groups, the previously picked subscriber
for sticky strategy may not be a valid member for the next group.
This fix is to key the picked subscriber pid with group ID.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 27, 2018

Pull Request Test Coverage Report for Build 3406

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.4%) to 56.631%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_shared_sub.erl 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
src/emqx_sys_mon.erl 1 18.33%
src/emqx_cm.erl 2 65.31%
src/emqx_router_helper.erl 3 23.4%
src/emqx_sm.erl 4 62.35%
src/emqx_broker_helper.erl 6 22.22%
Totals Coverage Status
Change from base Build 3384: -0.4%
Covered Lines: 2357
Relevant Lines: 4162

💛 - Coveralls
@spring2maz spring2maz force-pushed the shared-subscriber-should-key-by-group-id branch 2 times, most recently from e010a32 to f7781b6 Sep 27, 2018
Prior to this change, if a producer session produces to two
or more shared subscriber groups, the previously picked subscriber
for sticky strategy may not be a valid member for the next group.
@spring2maz spring2maz force-pushed the shared-subscriber-should-key-by-group-id branch from f7781b6 to 1351b53 Sep 27, 2018
@emqplus emqplus self-assigned this Sep 28, 2018
@emqplus emqplus added the Enhancement label Sep 28, 2018
@emqplus emqplus added this to the 3.0-beta.4 milestone Sep 28, 2018
@emqplus emqplus merged commit 3bab3cb into emqx30 Sep 28, 2018
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.4%) to 56.631%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@turtleDeng turtleDeng deleted the shared-subscriber-should-key-by-group-id branch Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.