Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support use certificate as username #1913

Merged
merged 3 commits into from Oct 26, 2018

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented Oct 23, 2018

Prior to this change, you can just use CN or EN field from the client
certificate as username.

This change add a new option to allow user to use Certificate directly as
username.

Prior to this change, you can just use CN or EN field from the client
certificate as username.

This change add a new option to allow user to use Certificate directly as
username.
@gilbertwong96 gilbertwong96 changed the title Support use certifate as username Support use certificate as username Oct 23, 2018
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 23, 2018

Pull Request Test Coverage Report for Build 3670

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 59.152%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_protocol.erl 3 5 60.0%
Totals Coverage Status
Change from base Build 3619: 0.2%
Covered Lines: 2540
Relevant Lines: 4294

💛 - Coveralls
peercert,
proto_ver,
proto_name,
ackprops,

This comment has been minimized.

Copy link
@tigercl

tigercl Oct 26, 2018

Collaborator

Please use 'ack_props' replace 'ackprops'

Prior to this change, ackprops is duplicated with ack_props

This change delete ackprops.
@turtleDeng turtleDeng merged commit 71b198f into emqx30 Oct 26, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 59.082%
Details
@turtleDeng turtleDeng deleted the cert_as_username branch Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.