Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test cases #1921

Merged
merged 4 commits into from Oct 26, 2018

Conversation

@tigercl
Copy link
Collaborator

tigercl commented Oct 26, 2018

  • Remove emqx_connection test suite

  • Improve emqx_banned, emqx_broker, emqx_bridge, emqx_pqueue, emqx_router test cases

  • Add emqx_mod_rewrites unit test

Gilbert and others added 3 commits Oct 26, 2018
Gilbert
Gilbert
* Improve emqx_banned, emqx_pqueue, emqx_router test cases

* Improve emqx_broker test case, and fix bug in emqx_broker

* Add emqx_hooks to CT_SUITES
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 26, 2018

Pull Request Test Coverage Report for Build 3676

  • 3 of 7 (42.86%) changed or added relevant lines in 2 files are covered.
  • 69 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+4.2%) to 63.146%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_broker.erl 2 6 33.33%
Files with Coverage Reduction New Missed Lines %
src/emqx_client.erl 3 55.38%
src/emqx_connection.erl 6 52.11%
src/emqx_protocol.erl 60 71.76%
Totals Coverage Status
Change from base Build 3619: 4.2%
Covered Lines: 2714
Relevant Lines: 4298

💛 - Coveralls
subscribed(Topic, SubId) when is_binary(Topic), ?is_subid(SubId) ->
length(ets:match_object(?SUBOPTION, {{Topic, {'_', SubId}}, '_'}, 1)) >= 1;
{Match, _} = ets:match_object(?SUBOPTION, {{Topic, {'_', SubId}}, '_'}, 1),

This comment has been minimized.

Copy link
@turtleDeng

turtleDeng Oct 26, 2018

Collaborator

ets:match_objec/3, If the table is empty, '$end_of_table' is returned.

@turtleDeng turtleDeng merged commit 8788cb2 into emqx30 Oct 26, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@tigercl tigercl deleted the improve_test_cases branch Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.