Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite emqx_mqueue.erl #1926

Merged
merged 2 commits into from Nov 3, 2018

Conversation

@spring2maz
Copy link
Contributor

spring2maz commented Oct 27, 2018

Fixed bugs:

  • Priority queue lack of a len + 1 logic in in/2

Changed behaviors:

  • Topics not found in priority table (from config) will be treated with default priority,
    instead of hasing topic name to a priority number.
  • Default priority is now configurable (it was always lower than all configured priorities)
  • The dropped message due to reaching max_len is now returned from in/2,
    so the queue owner (in/2 caller) can perform autopsy on it
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 27, 2018

Pull Request Test Coverage Report for Build 3692

  • 30 of 33 (90.91%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 63.492%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_local_bridge.erl 0 3 0.0%
Totals Coverage Status
Change from base Build 3682: 0.02%
Covered Lines: 2727
Relevant Lines: 4295

💛 - Coveralls
@spring2maz spring2maz requested review from emqplus, tigercl, turtleDeng, gilbertwong96 and terry-xiaoyu and removed request for emqplus Oct 27, 2018
spring2maz added 2 commits Oct 21, 2018
Fixed bugs:

- Priority queue lack of a `len + 1` logic in `in/2`

Changed behaviors:

- Topics not found in priority table (from config) will be treated with default priority,
  instead of hasing topic name to a priority number.
- Default priority is now configurable (it was always lower than all configured priorities)
- The dropped message due to reaching `max_len` is now returned from `in/2`,
  so the queue owner (`in/2` caller) can perform autopsy on it
@spring2maz spring2maz merged commit 7ad3a63 into emqx30 Nov 3, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 63.492%
Details
@spring2maz spring2maz deleted the rewrite-mqueue branch Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.