Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type validation for User-Property #1969

Merged
merged 1 commit into from Nov 19, 2018

Conversation

@manifest
Copy link
Contributor

manifest commented Nov 18, 2018

There is no User-Property type but UTF8-String-Pair. At the moment it is impossible to publish message that includes User-Property for that reason.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 18, 2018

Pull Request Test Coverage Report for Build 3791

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 61.475%

Files with Coverage Reduction New Missed Lines %
src/emqx_broker.erl 3 66.47%
Totals Coverage Status
Change from base Build 3753: -0.07%
Covered Lines: 2743
Relevant Lines: 4462

💛 - Coveralls
@gilbertwong96

This comment has been minimized.

Copy link
Contributor

gilbertwong96 commented Nov 18, 2018

Thanks for your contribution, but this change decrease the coverage of the test cases. I have to dig into the reason.

@manifest

This comment has been minimized.

Copy link
Contributor Author

manifest commented Nov 18, 2018

It seems to me that some of previous commits introduced the coverage loss. I appreciate your quick response.

@turtleDeng turtleDeng merged commit 9d67a64 into emqx:emqx30 Nov 19, 2018
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.07%) to 61.475%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.