Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dep size #1981

Merged
merged 5 commits into from Nov 26, 2018

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented Nov 23, 2018

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 23, 2018

Pull Request Test Coverage Report for Build 3875

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 66 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.07%) to 61.134%

Files with Coverage Reduction New Missed Lines %
src/emqx_broker.erl 3 66.47%
src/emqx_logger.erl 9 28.13%
src/emqx_protocol.erl 54 72.83%
Totals Coverage Status
Change from base Build 3850: -0.07%
Covered Lines: 2770
Relevant Lines: 4531

💛 - Coveralls
Copy link
Contributor

spring2maz left a comment

why hex-emqx
erlang.mk supports hex

Copy link
Contributor

spring2maz left a comment

Update rebar config too

@gilbertwong96 gilbertwong96 merged commit d13c5f8 into emqx30 Nov 26, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 61.143%
Details
@turtleDeng turtleDeng deleted the reduce-dep-size branch Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.