Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove simple log handler at startup #2000

Merged
merged 1 commit into from Nov 30, 2018

Conversation

@terry-xiaoyu
Copy link
Contributor

terry-xiaoyu commented Nov 28, 2018

The simple logger handler is not removed if we set the log.to=file in
emqx.conf.

{18-11-28 20:18}EMQ:~/code/emqx30/_rel/emqx@emqx30✗✗✗✗✗✗ emqer%
➜  ./bin/emqx_ctl log handlers list
LogHandler(id=file, level=error, destination=log/emqx.log)
LogHandler(id=simple, level=all, destination=unknown)

This might be an issue of OTP logger:
https://bugs.erlang.org/browse/ERL-788

I set the error_logger to silent as a workaround.

The simple logger handler is not removed if we set the `log.to=file` in
emqx.conf.

This might be an issue of OTP logger:
https://bugs.erlang.org/browse/ERL-788

I set the error_logger to silent as a workaround.
@terry-xiaoyu terry-xiaoyu requested review from spring2maz and emqplus and removed request for spring2maz Nov 28, 2018
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 28, 2018

Pull Request Test Coverage Report for Build 3902

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.134%

Totals Coverage Status
Change from base Build 3899: 0.0%
Covered Lines: 2770
Relevant Lines: 4531

💛 - Coveralls
@terry-xiaoyu terry-xiaoyu merged commit 76d5ded into emqx30 Nov 30, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 61.134%
Details
@terry-xiaoyu terry-xiaoyu deleted the remove_simple_logger_at_startup branch Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.