Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch commit for metrics #2001

Merged
merged 7 commits into from Nov 30, 2018

Conversation

@tigercl
Copy link
Collaborator

tigercl commented Nov 29, 2018

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 29, 2018

Pull Request Test Coverage Report for Build 3941

  • 25 of 30 (83.33%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 61.592%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_connection.erl 2 3 66.67%
src/emqx_ws_connection.erl 2 3 66.67%
src/emqx_session.erl 5 8 62.5%
Totals Coverage Status
Change from base Build 3904: 0.3%
Covered Lines: 2808
Relevant Lines: 4559

💛 - Coveralls
Copy link
Contributor

emqplus left a comment

Should not create a timer for batch commit of metrics

Copy link
Contributor

emqplus left a comment

Please improve the hold/3, commit/0 functions

src/emqx_metrics.erl Show resolved Hide resolved
src/emqx_metrics.erl Show resolved Hide resolved
test/emqx_session_SUITE.erl Outdated Show resolved Hide resolved
@emqplus emqplus merged commit fde5fbe into emqx30 Nov 30, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 61.592%
Details
@emqplus emqplus deleted the batch_metrics branch Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.