Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move extra vm args to a separate vm.args file #2033

Merged
merged 4 commits into from Dec 14, 2018

Conversation

@terry-xiaoyu
Copy link
Contributor

terry-xiaoyu commented Dec 5, 2018

I added a new vm.args file in PR emqx/emqx-rel#280.
The vm configs in emqx.conf will be merged into that vm.args at emqx startup.

@spring2maz

This comment has been minimized.

Copy link
Contributor

spring2maz commented Dec 6, 2018

Not sure if it's a good idea to suddenly stop supporting these args in emqx.conf.
IMHO. we can stop providing default values, even remove them from documentation,
but it's better to continue supporting args that are already provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 8, 2018

Pull Request Test Coverage Report for Build 4050

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 63.994%

Files with Coverage Reduction New Missed Lines %
src/emqx_sm.erl 1 71.08%
src/emqx_broker.erl 6 67.92%
Totals Coverage Status
Change from base Build 4003: -0.04%
Covered Lines: 2913
Relevant Lines: 4552

💛 - Coveralls
@terry-xiaoyu terry-xiaoyu changed the title Move some vm args to file vm.args Move extra vm args to file vm.args Dec 10, 2018
@terry-xiaoyu terry-xiaoyu changed the base branch from emqx30 to emqx32 Dec 10, 2018
@emqplus emqplus added the Enhancement label Dec 10, 2018
@emqplus emqplus added this to the 3.1-beta.1 milestone Dec 10, 2018
@emqplus emqplus self-assigned this Dec 10, 2018
@emqplus emqplus merged commit 7c7d6b0 into emqx32 Dec 14, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@emqplus emqplus deleted the vm_args branch Dec 14, 2018
@terry-xiaoyu terry-xiaoyu changed the title Move extra vm args to file vm.args Move extra vm args to a separate vm.args file Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.