Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge disk storage #2053

Merged
merged 18 commits into from Dec 28, 2018

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented Dec 13, 2018

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 13, 2018

Pull Request Test Coverage Report for Build 4092

  • 9 of 40 (22.5%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 64.191%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_client.erl 1 3 33.33%
src/emqx_bridge.erl 8 37 21.62%
Files with Coverage Reduction New Missed Lines %
src/emqx_bridge.erl 2 52.38%
Totals Coverage Status
Change from base Build 4033: 0.2%
Covered Lines: 2938
Relevant Lines: 4577

💛 - Coveralls
##
## Value: String
## Default: /tmp/emqx_aws_bridge/
bridge.aws.queue.replayq_dir = /tmp/emqx_aws_bridge/

This comment has been minimized.

Copy link
@turtleDeng

turtleDeng Dec 13, 2018

Collaborator

bridge.aws.queue.replayq_dir = {{ platform_data_dir }}/emqx_aws_bridge/

@emqplus emqplus changed the base branch from emqx30 to emqx32 Dec 14, 2018
gilbertwong96 and others added 2 commits Dec 17, 2018
Gilbert
@turtleDeng turtleDeng changed the base branch from emqx32 to emqx30 Dec 24, 2018
@turtleDeng turtleDeng changed the base branch from emqx30 to emqx32 Dec 24, 2018
@gilbertwong96 gilbertwong96 changed the base branch from emqx32 to master Dec 27, 2018
Prior to this change, @turtle merged emqx30 to master branch and it
cause some problems. For example, there are still some codes using
lager to print log and there is one local function which is not been
used by other function.

This change fix this issue.
@turtleDeng turtleDeng changed the base branch from master to emqx30 Dec 28, 2018
@turtleDeng turtleDeng changed the base branch from emqx30 to emqx32 Dec 28, 2018
Prior to this change, the bugs in delete function would reset the
state.

I fix it.
@gilbertwong96 gilbertwong96 force-pushed the bridge-disk-storage branch from 277d5f4 to 1995e68 Dec 28, 2018
gilbertwong96 and others added 4 commits Dec 28, 2018
@terry-xiaoyu terry-xiaoyu merged commit 8474f48 into emqx32 Dec 28, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 63.749%
Details
@terry-xiaoyu terry-xiaoyu deleted the bridge-disk-storage branch Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.